search

OpenUpSA / municipal-data

API and website for exploring municipal financial performance.
https://municipalmoney.gov.za/
MIT License
41 stars 15 forks source link

Dependency updates #726

Closed michaelglenister closed 7 months ago

michaelglenister commented 9 months ago

Issue: https://trello.com/c/F3s5xy9S/735-dependency-updates

paulmwatson commented 8 months ago

@michaelglenister The upgrades is triggering SASS syntax errors in the tests e.g.:

scss.errors.SassSyntaxError: Syntax error after '#ddd ': Found '!important' but expected one of ",", ":", ADD, ALPHA_FUNCTION, AND, BANG_IMPORTANT, BAREWORD, COLOR, DIV, DOUBLE_QUOTE, END, EQ, FNCT, GE, GT, IF_FUNCTION, INTERP_END, INTERP_START, LE, LITERAL_FUNCTION, LPAR, LT, MOD, MUL, NE, NOT, NUM, OR, RPAR, SIGN, SINGLE_QUOTE, SUB, URL_FUNCTION, VAR

Either we need to update the SCSS syntax (including !important etc.) or find a way to disable checking/linting.

I can replicate this in dev with:

docker-compose run --rm scorecard python manage.py collectstatic --no-input
michaelglenister commented 8 months ago

@paulmwatson I'm not managing to reproduce that after the changes I added