search

OpenUpSA / wazimap-ng-ui

User interface for Wazimap next generation. See also https://github.com/OpenUpSA/wazimap-ng
https://geo.vulekamali.gov.za/
Apache License 2.0
5 stars 16 forks source link

In the case of long text in the tooltips, the text should automatically collapse with a "see more" link in each long section #186

Closed adieyal closed 3 years ago

adieyal commented 3 years ago

0.12

https://trello.com/c/1X8aZ5p7/608-in-the-case-of-long-text-in-the-tooltips-the-text-should-automatically-collapse-with-a-see-more-link-in-each-long-section

milafrerichs commented 3 years ago

after discussion with @adieyal we would like to change this a little bit.

for now we just show the name of the point and the button show more when you click the button the new more info will show up. and then we will create a new config for the admin to chose which data properties to show in addition to the name.

@emre2038 can you implement that into your current PR?

emre2038 commented 3 years ago

so the tooltip will look like : image

when more info is clicked we will show the modal : image

correct?

adieyal commented 3 years ago

Yep - it will be refined soon but for now that's it.

On Fri, Jan 22, 2021 at 11:08 AM emre2038 notifications@github.com wrote:

so the tooltip will look like : [image: image] https://user-images.githubusercontent.com/53019884/105470333-79a53d00-5caa-11eb-9fd9-96ea37fb59dc.png

when more info is clicked we will show the modal : [image: image] https://user-images.githubusercontent.com/53019884/105470344-7d38c400-5caa-11eb-86bb-7e75ea24a134.png

correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenUpSA/wazimap-ng-ui/issues/186#issuecomment-765253640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADGXMWFDLSMGQCOJX7DMS3S3E6BRANCNFSM4ULVITZQ .

--

Adi Eyal Director, OpenUp 1 Thicket Street, Newlands, Cape Town www.openup.org.za | +27 21 671 6306

Facebook https://www.facebook.com/OpenUpSA/ | Twitter https://twitter.com/openupsa | GitHub https://github.com/openupsa/

OpenUp is a non-profit organisation registered with the South African Department of Social Development, number 133-850NPO. Licensed under a Creative Commons Attribution 4.0 International License.

emre2038 commented 3 years ago

this is done, I updated my PR

milafrerichs commented 3 years ago

@emre2038 can you open a new PR with the addition that if you close one of the info windows (modal or tooltip) the other closes as well? thanks.