search

OpenVPN / openvpn-build

OpenVPN Build
326 stars 238 forks source link

msi: use SIDs instead of built-in group names #674

Closed lstipakov closed 5 months ago

lstipakov commented 5 months ago

Group names are localized in some localizations, so we have to use SIDs.

Fixes https://github.com/OpenVPN/openvpn-build/issues/671.

cron2 commented 5 months ago

code change is in line with the documentation under https://learn.microsoft.com/en-us/windows/win32/secauthz/well-known-sids - so, looks good to me. Would be good to have a "now it works" confirmation from #671

lstipakov commented 5 months ago

Got a confirmation from a colleague with Brazilian Portuguese localization that this indeed fixes the problem, so IMO this can be merged.