search

OpenVPN / openvpn-gui

OpenVPN GUI is a graphical frontend for OpenVPN running on Windows 7 / 8 / 10. It creates an icon in the notification area from which you can control OpenVPN to start/stop your VPN tunnels, view the log and do other useful things.
Other
1.38k stars 397 forks source link

Update openvpn-gui-res-fr.rc #642

Closed bubuleur closed 11 months ago

bubuleur commented 11 months ago

Hello attached the update of the French translation of OpenVPN how to see if my translation is good? Thanks

lstipakov commented 11 months ago

Merci beaucoup! I'll ask a French-speaking colleague to check it. Meanwhile there is at least one issue:

IDS_NFO_STATE_DISCONNECTING Déconnexion"

The opening quote mark is missing.

bubuleur commented 11 months ago

Merci beaucoup! I'll ask a French-speaking colleague to check it. Meanwhile there is at least one issue:

IDS_NFO_STATE_DISCONNECTING Déconnexion"

The opening quote mark is missing.

Merci à toi pour tes remarques

bubuleur commented 11 months ago

Do you know how I can see directly on the software if my translation is good?

selvanair commented 11 months ago

You can download the GHA build executable that includes your PR from this link. https://github.com/OpenVPN/openvpn-gui/actions/runs/5715781857#artifacts If you are on 64 bit Windows use the one named openvpn-gui_x64 -- otherwise choose an appropriate one from the list.

lstipakov commented 11 months ago

@selvanair @flichtenheld shall we squash and merge?

bubuleur commented 11 months ago

I see that most of suggestions are addressed and some translations have changed a bit. Looks good to me.

Were you able to watch too? I changed some words because on the software you don't see the full words

selvanair commented 11 months ago

I changed some words because on the software you don't see the full words

We can change the text box sizes to accommodate longer phrases. I will take a quick look.

selvanair commented 11 months ago

All look good except the help window where the last line is truncated (the one that pops up when openvpn-gui.exe --help is run from the command line). But, there are a number of outdated options such as allow_edit and allow_service in the help text removing which will fix this. I'll follow with a patch to remove obsolete options in the help text in all languages.

+1 to squash and merge this.