search

OpenVPN / openvpn-gui

OpenVPN GUI is a graphical frontend for OpenVPN running on Windows 7 / 8 / 10. It creates an icon in the notification area from which you can control OpenVPN to start/stop your VPN tunnels, view the log and do other useful things.
Other
1.38k stars 397 forks source link

localisation broken #648

Open chipitsine opened 10 months ago

chipitsine commented 10 months ago

image

built on win10 by VS 17.7.2

well. it does not happen when installing an installer from https://openvpn.net also, I'm curious, can we change 'графический интерфейс OpenVPN' --> 'OpenVPN' ?

lstipakov commented 10 months ago

Do you use FAR, or is it Norton Commander? :)

This might be a duplicate of https://github.com/OpenVPN/openvpn-gui/issues/491. Looks like none of us have had time to investigate it.

I agree, Графический интерфейс looks completely unnecessary. Feel free to submit a PR.

ilia-shipitsin commented 10 months ago

Do you use FAR, or is it Norton Commander? :)

This might be a duplicate of #491. Looks like none of us have had time to investigate it.

I agree, Графический интерфейс looks completely unnecessary. Feel free to submit a PR.

as I guess installers are built on en_us locale. while locally I use ru_ru. I'll check that.

that's FAR

chipitsine commented 10 months ago

I added BOM to res/openvpn-gui-res-ru.rc and issue is gone

chipitsine commented 10 months ago

I'll submit patch for sussian localization. for other I'd suggest to wait for feedback

chipitsine commented 10 months ago

@selvanair , do you know somehow whether BOM is supposed to be there or maybe some automatic validation "that is good rc file"

selvanair commented 10 months ago

@selvanair , do you know somehow whether BOM is supposed to be there or maybe some automatic validation "that is good rc file"

We use pragma code_page(65001) so that all res files should get interpreted as UTF-8. We do not do any validation during build. But that doesn't appear to be the issue here as the content of the rc files appear to be valid UTF-8 and local builds I have tested displays these correctly.

Why some builds lead to corrupted text and some not is unclear to me.

Neustradamus commented 5 months ago

Dear @OpenVPN,

Have you progressed on this problem?