Improve "OpenVPN GUI" tooltip handling

OpenVPN / openvpn-gui

OpenVPN GUI is a graphical frontend for OpenVPN running on Windows 7 / 8 / 10. It creates an icon in the notification area from which you can control OpenVPN to start/stop your VPN tunnels, view the log and do other useful things.

Other

1.38k stars 397 forks source link

Improve "OpenVPN GUI" tooltip handling #649

Closed lstipakov closed 10 months ago

lstipakov commented 10 months ago

ping @chipitsine

chipitsine commented 10 months ago

I'm not sure why do we have a space for some languages

(also, I think this should be "OpenVPN GUI" for all languages without customization, but ok, as a first step we can just cut down russian translation)

selvanair commented 10 months ago

As @chipitsine pointed out, I think we need a trailing space as we append the connected message to this when there are active connections. Not sure why not all language strings have that space.

Just replacing IDS_TIP_DEFAULT by "OpenVPN GUI " in tray.c without localization may be better.

lstipakov commented 10 months ago

Yeah makes sense, I'll do the change.

selvanair commented 10 months ago

Checking again: we have a starting "\n" in IDS_TIP_CONNECTED so space is redundant?

lstipakov commented 10 months ago

Let's use PACKAGE_NAME instead of hardcoded "OpenVPN GUI".