search

OpenVPN / openvpn3-linux

OpenVPN 3 Linux client
GNU Affero General Public License v3.0
563 stars 151 forks source link

Spelling Error machineid.cpp #76

Closed keefer223 closed 3 years ago

keefer223 commented 3 years ago

I was building openVPN3 from source code. During the build on DEBIAN 11

make[2]: [Makefile:3682: src/common/machineid.o] Error 1 make[2]: Leaving directory '/home/keith/openvpn3-linux' make[1]: [Makefile:3704: all-recursive] Error 1 make[1]: Leaving directory '/home/keith/openvpn3-linux' make: *** [Makefile:2335: all] Error 2

src/common/machineid.cpp:152 -source = MachineID::SourceType::None;
+source = MachineID::SourceType::NONE;

dsommers commented 3 years ago

Thank you! Yes, this is a silly mistake. But this is at the same time in the code section related to building against mbed TLS. Is this your intention? We are not putting much energy into mbed TLS support these days, as mbed TLS development is fairly slow, lacking TLSv1.3 support and performance is generally not good compared against OpenSSL. At the same time, the last few years OpenSSL has improved on the development side and is now a well funded project with dedicated developers. So the concerns which surfaced in regards to Heartbleed is not such a big concern with OpenSSL longer.

dsommers commented 3 years ago

This should be resolved in commit ba419df7fc7da060857d83538225cebe8eab18f5.