Reproducible Build - Githubissues

OpenVPN / ovpn-dco-win

OpenVPN Data Channel Offload driver for Windows

MIT License

47 stars 22 forks source link

Reproducible Build #1

Closed mfil closed 3 years ago

mfil commented 3 years ago

I'm making this pull request for further comments. I asked on IRC on Friday, and people seem to prefer that I send the commits to the mailing list before they're included.

This pull request makes builds of ovpn-dco.sys reproducible by:

configuring the compiler and linker for reproducible builds (including submodule update)
force-inlineing a (template) function because its instantiations appeared in a non-deterministic order
~~including the expected hash for ovpn-dco.sys~~

~~I couldn't build the CLI exe yet.~~

lstipakov commented 3 years ago

Could you extract DMF changes into separate commit, which will become something like "Update link to DMF submodule" ?

mfil commented 3 years ago

Could you extract DMF changes into separate commit, which will become something like "Update link to DMF submodule" ?

Done!

I also fixed the path for the wpp file and added instructions for reproducible builds to the README.

I removed the file with the hash, as discussed, but when you have a release, you should write down the hash somewhere, so that people know if they got the build right. We don't want people to worry that they got a bad binary because they made a mistake!