OpenVPN / puppet-openvpnas

Puppet module for managing the OpenVPN Access Server
BSD 2-Clause "Simplified" License
5 stars 5 forks source link

Improve openvpnas module #2

Closed sahaqaa closed 6 months ago

sahaqaa commented 7 months ago

This PR was tested with Ubuntu 22.04 LTS and AlmaLinux 8 -> it's working OK

Puppet server information

Puppet: 7.9.5
Ruby: ruby 2.7.7p221 (2022-11-24 revision 168ec2b1e5) [x86_64-linux]
Distribution: Ubuntu 20.04 LTS
sahaqaa commented 7 months ago

List of supported OS distributions was taken from here: https://openvpn.net/vpn-server-resources/openvpn-access-server-system-requirements/ (As of now this list a little outdated, in 2.13.0 also added Debian 12 support https://openvpn.net/vpn-server-resources/release-notes/) -> i.e. "metadata.json" contains all currently supported operating systems

mattock commented 6 months ago

The changes look good afaics. There is no active maintainer for this module so if you want, I think you could take over the responsibility.

sahaqaa commented 6 months ago

There is no active maintainer for this module so if you want, I think you could take over the responsibility.

I could try to do it.

For now ideally there is two more actions that would be good to to:

1/ Add new tag in GitHub repo I can see here https://github.com/OpenVPN/puppet-openvpnas/tags that there are 3 tags 0.3.1 0.3.0 0.2.0

But at Puppet Forge https://forge.puppet.com/modules/openvpn/openvpnas/readme there are four tags: 0.3.2 0.3.1 0.3.0 0.2.0

Ideally new unique version of tag should be added for repo https://github.com/OpenVPN/puppet-openvpnas/tags

2/ Upload or release to Puppet Forge (with newly created tag) // Also in file https://github.com/OpenVPN/puppet-openvpnas/blob/master/metadata.json new tag should be added

("version": "0.3.2", )

after that new release should be done to Puppet Forge https://forge.puppet.com/modules/openvpn/openvpnas/readme (i myself haven't yet know how to add / post release to Forge)