search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
802 stars 238 forks source link

Use CurrentAddress for MAC instead of PermanentAddress #128

Closed selvanair closed 4 years ago

selvanair commented 4 years ago

While checking packets for proxy arp etc., use of either the current or permanent address worked in the past when we used to overwrite the PermanentAddress with the user-defined value (if any). Since commit f4f6464cac we directly set the CurrentAddress to the customized value and leave the PermanentAddress unchanged.

The DHCP code is unchanged as it already uses the CurrentAddress.

Also update the description of these fields in comments to better match the code.

Signed-off-by: Selva Nair selva.nair@gmail.com

Unlike ARP, NA works even without this change to my surprise. Probably because its only the destination MAC that is wrong in the response, the IP is correct. Looks like magic to me.

cron2 commented 4 years ago

ACK. This is, in hindsight, a very obvious omission.

I went through all the files now looking for "tAddress" and txpath.c seems to be the only place that was using the wrong type.

So, I think, your patch does the right thing and there is nothing else which is missing. Thanks!