search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
765 stars 238 forks source link

Added check to create dist folder if its does not exists already and Customising name of NSIS exe package #133

Closed shkpk closed 3 years ago

shkpk commented 3 years ago

This PR is to fix issue #132

mattock commented 3 years ago

@shkpk afaics this look good. Did you test building an MSM with this?

shkpk commented 3 years ago

@shkpk afaics this look good. Did you test building an MSM with this?

@mattock this change is specifically targeting NSIS build. There is no code change effecting MSM.

shkpk commented 3 years ago

@shkpk afaics this look good. Did you test building an MSM with this?

@mattock this change is specifically targeting NSIS build. There is no code change effecting MSM.

I updated msm packages to use PRODUCT_PACKAGE_NAME as NSIS installer for customized name of exe/msm

lstipakov commented 3 years ago

I compile-tested MSM part and it looks fine. Could you rebase your PR on top of master and squash to the reasonable amount of commits?

shkpk commented 3 years ago

I compile-tested MSM part and it looks fine. Could you rebase your PR on top of master and squash to the reasonable amount of commits?

Done 👍

mattock commented 3 years ago

There are still several merge commits and two commits that unnecessary share the same commit message. I would just do

git reset --soft <last-upstream-commit-id>

Then add/commit the modified files from scratch.

shkpk commented 3 years ago

@mattock Opened new PR https://github.com/OpenVPN/tap-windows6/pull/136