OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
763 stars 237 forks source link

ndis miniport characteristics missing #15

Open sstjohn opened 8 years ago

sstjohn commented 8 years ago

Commit 2ab5e88 introduced a 'g' before the definition of PRODUCT_TAP_WIN_CHARACTERISTICS in version.m4, which doesn't match the regex in buildtap.py's BuildTAPWindows.parse_version_m4 method. Consequently, the generated INF describes the characteristics of the device as "" (the empty string), which erroneously becomes a 0 in the registry, rather than the correct value of 0x81 (NCF_VIRTUAL | NCF_HAS_UI).

mattock commented 8 years ago

Hi,

We're in the process of getting an EV code-signing certificate for signing the tap-windows6 driver. Once that is taken care of, we can fix this bug and rebuild. If we did publish a new driver now, it will not (afaik) work on Windows 10, because of Microsoft's new driver signing policy.