search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
765 stars 238 forks source link

Code changes to with Aruba VIA client #150

Closed BiradarV closed 1 year ago

BiradarV commented 1 year ago

Modified the device name and added condition to work Aruba VIA client.

cron2 commented 1 year ago

With the commit as is, there is no chance that it can get merged.

It is lacking a proper commit message to explain these changes (in detail).

More problematic is the sprinkling of HP copyright messages across all files, and changing of the resource.rc names - you can do that, as means of a fork, but we can not merge it back.

So if you want to do a useful PR, isolate the changes that can go upstream (no changing of TAP_WIN_SUFFIX, VER_LEGALCOPYRIGHT_STR, VER_COMPANYNAME_STR, etc) and resubmit with a good commit message that explains what is changed and why.