search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

Fix linefeeds in license.txt #27

Closed mattock closed 7 years ago

mattock commented 7 years ago

Typically Git on Windows is configured to check out files with CRLF linefeeds. This meant that the extra linefeed conversion step in buildtap.py was not only unnecessary, but also harmful. The symptom was that the NSI installer showed the whole license.txt on a single line.

Signed-off-by: Samuli Seppänen samuli@openvpn.net

chipitsine commented 7 years ago

why no to use .gitattributes instead ?

https://help.github.com/articles/dealing-with-line-endings/

mattock commented 7 years ago

I think .gitattributes would complement this PR nicely. I would limit its use to files which are user-facing (e.g. the license file) and need to have DOS linefeeds.

In any case, this commit was tested by Selva in an earlier PR, so I'll merge it now.