search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

Allow getting code-signing certificate from the machine store #32

Closed mattock closed 6 years ago

mattock commented 7 years ago

This can be useful if one needs to use two code-signing certificates that have identical names, or if the machine store is the preferred location.

Signed-off-by: Samuli Seppänen samuli@openvpn.net

mattock commented 7 years ago

Note that this updates buildtap.py usage info in README.rst to match reality. As a side-effect --certfile and --certpw options also get proper documentation.

chipitsine commented 7 years ago

this conflicts with https://github.com/OpenVPN/tap-windows6/pull/33 :)

mattock commented 7 years ago

Ah, indeed so. I will fix this soon and merge it with lazy-ACK. Unless someone gives a real ACK :smile:

mattock commented 7 years ago

Merge conflicts fixed.

mattock commented 7 years ago

I'll merge this with lazy-ACK if nobody complains soon :smile: .

mattock commented 6 years ago

I believe the rationale for this PR was to be able to sign with two different certificates (SHA1 and SHA2) which had similar/same names in the certificate store. As we won't be signing with SHA1 anymore I will close this PR. If somebody needs this feature please issue another PR.