search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

is it possible to add "tapinstall.exe" to this repo ? #35

Open chipitsine opened 7 years ago

chipitsine commented 7 years ago

I want to reproduce tap-windows6 build in AppVeyor, "tapinstall.exe" is missing. also, there's no clear guide where am I supposed to download it.

mattock commented 7 years ago

Tapinstall.exe is actually called devcon.exe. The source code is available, but it has - or used to have - pretty severe limitations on redistribution. Also, building it can be tricky with recent Visual Studio / C compiler versions. Right now I'm using an old tapinstall.exe build by @jamesyonan.

That said, Microsoft has been actively pushing its code into GitHub. So it is possible that devcon.exe sources have been open sourced as well. If that is the case, we could fix devcon.exe sources so that they compile cleanly and even include them in the tap-windows6 repository.

chipitsine commented 7 years ago

Yes, I saw devcon sources on github, what kind of modification should be made to its source?

mattock commented 7 years ago

Where are the sources exactly?

chipitsine commented 7 years ago

https://github.com/Microsoft/Windows-driver-samples/tree/master/setup/devcon

chipitsine commented 7 years ago

it is not hard to build it in AppVeyor. it is pretty recent, so, it builds fine

mattock commented 7 years ago

Thanks! The license is MS-PL which is an OSI-approved license. I think we should fork https://github.com/Microsoft/Windows-driver-samples/ under the OpenVPN organization and move on from there. Two ideas:

  1. Build tapinstall.exe from sources in buildtap.py
  2. Build static 32-bit and 64-bit tapinstall.exe manually and place the resulting binaries to the tap-windows6 repository.

Thoughts?

chipitsine commented 7 years ago

https://ci.appveyor.com/project/chipitsine/windows-driver-samples/build/artifacts

chipitsine commented 7 years ago

what modification is required to the source?

chipitsine commented 7 years ago

well, we can add windows-driver-sample as a submodule to tap-windows6. and as for buildtap.py ... brrrr.... I wish to convert to Powershell/MSBuild and combine with https://github.com/mattock/sign-tap6

mattock commented 7 years ago

what modification is required to the source?

Can't recall. If you managed to build it, then my problem was just some incompatibility between my Visual Studio and devcon source versions.

well, we can add windows-driver-sample as a submodule to tap-windows6.

Indeed. If we don't have to modify the devcon sources at all, then that would be sufficient.

mattock commented 6 years ago

Simon on openvpn-devel has a tapinstall.exe replacement. And I believe @jkunkee mentioned that devcon.exe sources are now available under MS-PL license which means we could easily bundle those. Or add those as a Git submodule.

jkunkee commented 6 years ago

Devcon is indeed now MS-PL and up on Github as @mattock described earlier in this thread. :)

@chipitsine, the only change I had to make was renaming the binary output from devcon.exe to tapinstall.exe. The current driver install process uses stock devcon.exe functionality.

53 makes it so no changes are needed to devcon's sources.