OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

Have the driver version display as major.minor.revision.build #48

Closed selvanair closed 5 years ago

selvanair commented 6 years ago

The driver version (taken from the INF) and the file version of tap0901.sys file (from its resource) will now display like 9.22.1.601.

The driver details tab will continue to show the text form of the version as "major.minor.revision major/minor". Eg., "9.22.1 9/22"

Signed-off-by: Selva Nair selva.nair@gmail.com


Appears to work fine as in the image below, but I would like to do some tests with a properly signed version. capture

selvanair commented 6 years ago

date change reverted

selvanair commented 6 years ago

@mattock : does this work as expected in your new test setup?

mattock commented 6 years ago

@selvanair I will test this once the test instances are up and accepting remote commands. I'm not quite there yet.

cron2 commented 5 years ago

I have tested Samuli's latest signed win10 driver, and it seems to do the right thing. Driver identifies in OpenVPN as 9.23, and in the "driver config" pane, it says "Treiberversion: 9.23.1.601". File version of tap0901.sys is "9.23.1 9/23", whatever that signifies, but it sort of all has the same base info. Better than before :-)