search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

Fix missing PRODUCT_PUBLISHER field in installer #51

Closed jkunkee closed 6 years ago

jkunkee commented 6 years ago

This patch adds the PRODUCT_PUBLISHER variable to the buildtap.py invocation of MakeNSIS. It also allows for MakeNSIS invocations with spaces in them.

This should address the fact that Product Publisher in Programs and Features is ${PRODUCT_PUBLISHER} instead of "OpenVPN Technologies, Inc." as reported on IRC.

mattock commented 6 years ago

Looks good. I assume the extra quotes are because value of PRODUCT_PUBLISHER has spaces in it?

jkunkee commented 6 years ago

Precisely. There are a few other character classes (parentheses, pipes, ampersands, etc.) that it can take care of too.

Sent from my Windows 10 phone [15254 - 16.0.9226.2120]

From: Samuli Seppänen Sent: Sunday, April 29, 2018 4:01 AM To: OpenVPN/tap-windows6 Cc: Jon Kunkee; Author Subject: Re: [OpenVPN/tap-windows6] Fix missing PRODUCT_PUBLISHER field ininstaller (#51)

Looks good. I assume the extra quotes are because value of PRODUCT_PUBLISHER has spaces in it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.