OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

Add ARM64 files to installer #57

Closed jkunkee closed 5 years ago

jkunkee commented 6 years ago

This passes my smoke test on ARM64. No code has changed since the 6.30 bump, so this should be good for x64 and x86 as well.

jkunkee commented 6 years ago

rebase onto master

cron2 commented 6 years ago

Hi,

On Tue, May 08, 2018 at 05:09:24PM -0700, Jon Kunkee wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/OpenVPN/tap-windows6/pull/57

On a cursory glance, this looks all logical. Of course the magic is in wow.nsh, which I won't claim to understand at all...

So this is "testing" again :-)

Jon, is there a way to test on ARM64 without buying a Surface tablet?

(I do have an rPI 3, but I assume that this won't do...)

Anything virtual?

gert

-- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany gert@greenie.muc.de

jkunkee commented 6 years ago

Unfortunately we don't have anything virtual at the moment, no. I'm happy to test things, though :)

jkunkee commented 6 years ago

And oh my goodness, yes, wow.nsh is some serious magic.

I did post a link to it on the NSIS forum: http://forums.winamp.com/showthread.php?t=453160

Looks like it probably won't be upstreamed, and it does have one small bug. I'll get that fixed shortly.

cron2 commented 5 years ago

It passed the smoke tests, and has been left out in the open for way too long, so merging it now.