search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
788 stars 237 forks source link

Throw exception when any buildtap.py system command fails #61

Closed rozmansi closed 5 years ago

rozmansi commented 6 years ago

Silently ignoring non-zero error levels returned by various build commands makes build process continue on error. In some scenarios build process does not detect missing or invalid command outputs and continues to produce an invalid result giving a false sense of success.

rozmansi commented 6 years ago

Please note, that AppVeyor build check of this PR will fail, because this PR is all about not ignoring build errors as AppVeyor does now.

chipitsine commented 6 years ago

it is very good that app veyor fails.

should we mark it as allowed failure for a while ?

rozmansi commented 6 years ago

I have opened a question on https://help.appveyor.com support forum about EWDK support. Should we switch back to Visual Studio 2015 + Windows Driver Kit 10 meanwhile?

chipitsine commented 6 years ago

I also opened a support ticket on VSTS regarding EWDK support. Maybe we'll have more luck there

chipitsine commented 6 years ago

as for app veyor, it better works with github issues (from my expirience)

cron2 commented 6 years ago

Hi,

On Sun, Jun 17, 2018 at 11:30:54PM -0700, Simon Rozman wrote:

Silently ignoring non-zero error levels returned by various build commands makes build process continue on error. In some scenarios build process does not detect missing or invalid command outputs and continues to produce an invalid result giving a false sense of success.

I think this is good, so an ACK from me.

What I cannot do right now is "test whether a normal standard build with this merged will succeed" (no build environment here yet) so I'd like to hear from Samuli "yes, this does not break anything for me"...

(And then he can merge it himself)

gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany gert@greenie.muc.de

rozmansi commented 5 years ago

This PR is superseeded by #68.