OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
785 stars 237 forks source link

hlk4: Fix support for changing MAC address #79

Closed sgstair closed 5 years ago

sgstair commented 5 years ago

Implemented the adapter's MAC address reading in the way that NDIS expects it to be done.

cron2 commented 5 years ago

Looks good to me.

While it might change behaviour in some conditions, what the code does now looks more like the original intention.

"PermanentAddress" and "CurrentAddress" are also much better defined - CurrentAddress is based on PermanentAddress, but could be changed via registry.

The "local administered address" check is required for HLK test.

ACK!