Introduce TAP adapter as a virtual device

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)

Other

785 stars 237 forks source link

Introduce TAP adapter as a virtual device #84

Closed rozmansi closed 4 years ago

rozmansi commented 5 years ago

One thing that I've had on the back of my mind for a while (but never got time to test it) was *IfType and *PhysicalMediaType settings in tap-windows6... Has anybody tried to change *IfType from IF_TYPE_ETHERNET_CSMACD to IF_TYPE_PROP_VIRTUAL and *PhysicalMediaType from NdisPhysicalMedium802_3 to NdisPhysicalMediumUnspecified yet? This would stop advertising tap-windows6 device as a physical Ethernet card, but a virtual device. Leaving *MediaType set to NdisMedium802_3, a virtual layer 2 device actually - namely a TAP device.

IMHO, this might solve a couple of things:

HP Envy notebooks switching WiFi off when OpenVPN connection is established issue
Simplify HLK tests:
- tap-windows6 is no longer a physical NIC and should no longer require physical hardware to test on
- Will tap-windows6 still require "Network.Ethernet.*" tests to be performed at all?

mattock commented 5 years ago

Thanks @rozmansi ! I will give this PR a go. I'll spin up a virtualized Windows Server 2019 HLK client and see how it goes.

schwabe commented 5 years ago

Even if it does not make HLK easier, it should be merged as it is more "correct"

cron2 commented 5 years ago

Hi,

On Tue, May 07, 2019 at 03:19:27AM -0700, Arne Schwabe wrote:

Even if it does not make HLK easier, it should be merged as it is more "correct"

We need testing across all supported OSes (Win7 to Win10 1809 and server variants), tun+tap mode, v4/v6 to see if this has unintended side effects.

Besides this, I'm also in favour of this change :-)

@mattock: ... maybe put up an I701 installer with this change...?

gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany gert@greenie.muc.de

mattock commented 4 years ago

Installer that includes this PR: https://build.openvpn.net/downloads/temp/tap-windows-9.24.2-I601.exe

mattock commented 4 years ago

Windows 10 / Server 2016 installer with PR #84 and #86:

https://build.openvpn.net/downloads/snapshots/tap-windows-9.24.2-I601.exe

cron2 commented 4 years ago

It seems to be the right fix, it got testing exposure and feedback from Selva and JJK, so go head for the 2.4.8 release.