search

OpenVPN / tap-windows6

Windows TAP driver (NDIS 6)
Other
785 stars 237 forks source link

Enable code analysis on Release|x64 builds #88

Closed rozmansi closed 5 years ago

rozmansi commented 5 years ago

This is a follow-up to https://sourceforge.net/p/openvpn/mailman/message/36697596/

cron2 commented 5 years ago

Hi,

On Wed, Jun 19, 2019 at 06:34:01AM -0700, Simon Rozman wrote:

-- Commit Summary --

  • Enable code analysis on Release|x64 builds

What does this do, exactly, and how can we see the results?

gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany gert@greenie.muc.de

rozmansi commented 5 years ago

It enables Visual Studio built-in code analysis (PREfast) after compile is complete. It increases the build time and it generates additional warnings, so it is disabled by default. However, the Static Driver Verifier Test that is failing in WHLK requires the report from code analysis.

The report is source code based, so it is enough to be generated only on one configuration|platform pair.

As the Driver Verification Log performed in the next step works for Release configurations only, I have picked Release|x64.

I usually resolve MSVC warnings immediately and have code analysis enabled on all configurations even Debug ones in my other projects. With the number of warnings in tap-windows6, some extra warnings from code analysis don't make it worth running always.

cron2 commented 5 years ago

sounds totally logical. No code changes, so nothing to review there. ACK, thanks.