OpenVidu / openvidu

OpenVidu Platform main repository
https://openvidu.io
Apache License 2.0
1.86k stars 464 forks source link

streamPropertyChanged not being raised neither on Publisher nor on Session #795

Open kazepis opened 1 year ago

kazepis commented 1 year ago

Describe the bug streamPropertyChanged is not being raised neither on Publisher nor on Session when sharing application window is resized

Expected behavior The 'streamPropertyChanged' should be raised on both the Publisher and the Session

Wrong current behavior The browser (chrome) console window shows the following log: Sending request: {method:"streamPropertyChanged", params: {"streamId":"str_SCR_KLwZ_con_I8pXNA23GH","property":"videoDimensions","newValue":"{\"width\":430,\"height\":816}","reason":"screenResized"}} But the streamPropertyChanged event is not raised

OpenVidu deployment info How is your OpenVidu Server instance deployed when you get the bug. A couple of possible examples are listed below:

Client device info (if applicable) Describe the client device(s) or platform(s) where you are able to replicate the error. For example:

kazepis commented 1 year ago

image The breakpoints in the callback function are never being hit. The sendRequest in line 647 is executed.

pabloFuente commented 1 year ago

If streamPropertyChanged event is not being triggered by the local Publisher or Session object, then it means that the sendRequest method is not finishing correctly. Furthermore, I think that the operation is hanging somehow, because even if it failes (let's imagine becasue of an incompatibility between openvidu-browser and the OpenVidu deployment versions), the operation should log the error line. The problem could be related to a network issue with the OpenVidu deployment? But in this case it would be very strange that the error only happens with this RPC operation and not others.

vsx-sieber commented 8 months ago

I am currently working on a Unity C# port of the openvidu-browser library and just stumbled upon this piece of code and was wondering: Does Openvidu server even listen to streamPropertyChanged events coming from the client? Your RPC reference does not mention this kind of "Client-Server method". Its only mentioned as a "Server event" originating from and emitted by the server.