Fix Stream.isSendScreen() for custom videoSource

OpenVidu / openvidu

OpenVidu Platform main repository

https://openvidu.io

Apache License 2.0

1.86k stars 464 forks source link

Fix Stream.isSendScreen() for custom videoSource #809

Closed semmel closed 1 year ago

semmel commented 1 year ago

The custom MediaStreamTrack provided as videoSource parameter in the Publisher factory functions is now examined by the Stream.isSendScreen() method if it is a screen sharing video track.

fixes #808

cruizba commented 1 year ago

Merged. I've formated for a typescript error: https://github.com/OpenVidu/openvidu/commit/cd7f8ae2828507d954cab209a53416b4ba479fa9

Can you confirm to me this works for your use case?

semmel commented 1 year ago

@cruizba Thanks a lot for fixing the TypeScript error (I am not the TypeScript guy) and sorting the logic! I am glad, I chose openvidu – great project!