search

OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
519 stars 169 forks source link

Updated test script #395

Closed intelmark closed 5 years ago

intelmark commented 5 years ago

Updating the test script provided by Jing.

Updated the README.md to reflect the updated script.

Signed-off-by: Mark Feldman mark.feldman@intel.com

1480c1 commented 5 years ago

Please check for whitespace and unnecessary tabbing

1480c1 commented 5 years ago

Note: The \ at the end of a line is only necessary to keep the newline if you have two sentences together

This is the first sentence.
This is the second sentence.

Becomes:

This is the first sentence. This is the second sentence.

This is the first sentence.\
This is the second sentence.

Becomes:

This is the first sentence. This is the second sentence.

This is the first sentence.
This is the second sentence.\

Becomes:

This is the first sentence. This is the second sentence.\

1480c1 commented 5 years ago

Also, make sure to either squash/fixup your commits locally on your own branch and force push before merging or use squash and merge when merging this PR

tianjunwork commented 5 years ago

Hi @intelmark Mark, I still see lots of \ from https://github.com/OpenVisualCloud/SVT-HEVC/blob/42d6474c7995d8dee9f6d8e76115ab8b51250fa5/Tests/README.md. Please check the *.md file from Github first before letting others to review. Hi @1480c1 Chris, thank you for code review. Sure, squash and merge will be used.

intelmark commented 5 years ago

Please read md file(view file) and make sure you remove all the \

Some are needed for formatting. Should look OK now

tianjunwork commented 5 years ago

Hi @intelmark will you or Jing Wang's team address the commits?