search

OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
519 stars 169 forks source link

Unbreak build on FreeBSD #419

Closed jbeich closed 4 years ago

jbeich commented 4 years ago

https://github.com/freebsd/freebsd/commit/4774ca6be082 and https://github.com/dragonflybsd/dragonflybsd/commit/086b156cdf18 declare ignore_handler_s in <stdlib.h> but SVT-HEVC includes it in the same file where a static copy is defined, causing a conflict. See error log. https://github.com/OpenVisualCloud/SVT-HEVC/blob/8382e4fd31c676c673920e476f329d59f9ee2f33/Source/Lib/Codec/EbEncHandle.c#L13 https://github.com/OpenVisualCloud/SVT-HEVC/blob/8382e4fd31c676c673920e476f329d59f9ee2f33/Source/Lib/Codec/EbEncHandle.c#L138-L146

Other BSD fixes are in #135.

tianjunwork commented 4 years ago

Hi @jbeich Jan, Thank you submitting this PR. You probably already noticed that SVT-AV1 string functions refactored by @jstebbins (Duplicate string functions in lib with different names) can also fix your issue. To keep SVT code sync between encoders, same refactor is preferred for long term fix. That means we would hold your PR and instead working on refactor. What is your opinion?

jbeich commented 4 years ago

I can wait for the refactor. Besides,#135 hasn't been merged yet. Most FreeBSD users build from ports (or use binary packages) where I've worked around via -D__STDC_WANT_LIB_EXT1__=0. Curiously, SVT-HEVC seems to be more popular than SVT-AV1.

tianjunwork commented 4 years ago

Thank you Jan providing the information :) I will let Chris @1480c1 comment on his PR #135.

tianjunwork commented 4 years ago

Hi @jbeich Jan, hopefully this PR will address your issue. https://github.com/OpenVisualCloud/SVT-HEVC/pull/422.

135 will be merged soon after validation.

jbeich commented 4 years ago

I confirm, builds fine on FreeBSD with both #135 and #422 merged. Mark as duplicate of #422.

tianjunwork commented 4 years ago

Thank you @jbeich Jan confirming the fix.