search

OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
517 stars 171 forks source link

Unpack fixes #476

Closed intelmark closed 4 years ago

intelmark commented 4 years ago

Some changes to make unpack process more consistent with other processes

1) Changed cast of unpackContexPtr from EB_PTR to EB_PTR* to match encHandlePtr->unpackContextPtr definition

2) EB_ENC_UnPack2D_TYPE identify is used for two different purposes - structure for parameters and for function type. Renamed definition in EbPackUnPack.h to EB_ENC_UnPack2D_FUNC_TYPE

3) Change UnPack2D function parameter to void and cast to UnPackContext_t in EbGetFullObject and EbGetEmptyObject calls

Signed-off-by: Mark Feldman mark.feldman@intel.com

tianjunwork commented 4 years ago

Hi Mark, some of your changes are included in my PR #467. Could you review those changes relevant to this PR? Thank you.

intelmark commented 4 years ago

@Tian, Junmailto:jun.tian@intel.com - Thanks for the heads up . There is some overlap – I’ll wait for your PR to get approved and re-evaluate these changes.

From: Jun notifications@github.com Sent: Friday, February 14, 2020 10:51 AM To: OpenVisualCloud/SVT-HEVC SVT-HEVC@noreply.github.com Cc: Feldman, Mark mark.feldman@intel.com; Author author@noreply.github.com Subject: Re: [OpenVisualCloud/SVT-HEVC] Unpack fixes (#476)

Hi Mark, some of your changes are included in my PR #467https://github.com/OpenVisualCloud/SVT-HEVC/pull/467. Could you review those changes relevant to this PR? Thank you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/OpenVisualCloud/SVT-HEVC/pull/476?email_source=notifications&email_token=AMC5UQQEJZ75QN4EPNYTQWDRC3KZ7A5CNFSM4KVMYPC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZ3P4Y#issuecomment-586397683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMC5UQS74U2FC437ZIE3Y4TRC3KZ7ANCNFSM4KVMYPCQ.

tianjunwork commented 4 years ago

Hi @intelmark , Mark, you could continue this PR now:) Thank you.