OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
516 stars 172 forks source link

Fix hang caused by OUT_ALLOC and remove macro #523

Closed tianjunwork closed 4 years ago

tianjunwork commented 4 years ago
  1. The reason of hang caused by OUT_ALLOC is lack of available output stream buffer. The fix is to seperate the outputBufferFifoInitCount from inputOutputBufferFifoInitCount. And increase its size.
  2. Remove the OUT_ALLOC macro.

Signed-off-by: Jun Tian jun.tian@intel.com

closes #514, #497

tianjunwork commented 4 years ago
Memory allocated at init. 1080p 4k 8k
with this PR 3.91GB 13.45GB 47.21GB
master 4.24GB 13.9GB 48.11GB

Speed gain for resolution below 1080p. No gain for resolution >= 1080p(4k, 8k almost the same). image image

tianjunwork commented 4 years ago

Finished test with -n 1000. No hang. No new failed cases other than the existing issues.

---------------------------------------------------------
Test Begin... 
Total Number of Tests: 2685
Total Passed: 2671
Percentage Passed: 99.47858473%
Time Elapsed: 1 day(s), 23 hour(s), 56 minute(s), 39 second(s)
---------------------------------------------------------
asm_test.txt:------------Failed-------------
asm_test.txt:------------Failed-------------
asm_test.txt:------------Failed-------------
asm_test.txt:------------Failed-------------
buffered_test.txt:------------Failed-------------
buffered_test.txt:------------Failed-------------
buffered_test.txt:------------Failed-------------
buffered_test.txt:------------Failed-------------
defield_test.txt:------------Failed-------------
defield_test.txt:------------Failed-------------
defield_test.txt:------------Failed-------------
defield_test.txt:------------Failed-------------
multi_channel_test.txt:------------Failed-------------
multi_channel_test.txt:------------Failed-------------
tianjunwork commented 4 years ago

Hi @intelmark @Austin-Hu , good to go?

intelmark commented 4 years ago

looks good! (aside from those test failures which we'll tackle separately)