OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
516 stars 172 forks source link

Uninitialized memory fix #537

Closed intelmark closed 4 years ago

intelmark commented 4 years ago

Fixing an issue reported by running the memory sanitizer on Linux. Initializing memory allocated for processing the command lines.

Signed-off-by: Mark Feldman mark.feldman@intel.com

tianjunwork commented 4 years ago

Hi Mark, could you paste the full report of memory sanitizer?

intelmark commented 4 years ago

From the Memory Sanitizer:

SVT-HEVC Encoder Uninitialized bytes in __interceptor_strcmp at offset 0 inside [0x71c000000000, 1) ==31263==WARNING: MemorySanitizer: use-of-uninitialized-value

0 0x562b882b8f12 in ReadCommandLine /repos/SVT-HEVC/Source/App/EbAppConfig.c:1279:25

#1 0x562b882bd6ee in main /repos/SVT-HEVC/Source/App/EbAppMain.c:143:20
#2 0x7f491b417b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#3 0x562b8823cde9 in _start (/repos/SVT-HEVC/Bin/Debug/SvtHevcEncApp+0x1dde9)

SUMMARY: MemorySanitizer: use-of-uninitialized-value /repos/SVT-HEVC/Source/App/EbAppConfig.c:1279:25 in ReadCommandLine Exiting

1480c1 commented 4 years ago

@intelmark please use triple backticks around the output to prevent pinging unrelated issues and pr

Uninitialized bytes in __interceptor_strcmp at offset 0 inside [0x71c000000000, 1)
==31263==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x562b882b8f12 in ReadCommandLine /repos/SVT-HEVC/Source/App/EbAppConfig.c:1279:25
#1 0x562b882bd6ee in main /repos/SVT-HEVC/Source/App/EbAppMain.c:143:20
#2 0x7f491b417b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#3 0x562b8823cde9 in _start (/repos/SVT-HEVC/Bin/Debug/SvtHevcEncApp+0x1dde9)

SUMMARY: MemorySanitizer: use-of-uninitialized-value /repos/SVT-HEVC/Source/App/EbAppConfig.c:1279:25 in ReadCommandLine
Exiting

https://community.openhab.org/t/how-to-use-code-fences/38383