OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
518 stars 170 forks source link

ffmpeg: Move lines to allow applying on master, 4.3, and 4.2 #572

Closed 1480c1 closed 4 years ago

1480c1 commented 4 years ago

Description

Move some of the lines to allow patching the master branch, 4.3, and 4.2 with the same file

tested with ffmpeg tags n4.2, n4.3, and n4.4-dev tested with ffmpeg branch master, release/4.2, and release/4.3

@guojiansheng0925 can you please review?

Issue

Author(s)

@1480c1

Performance impact

Merge method

guojiansheng0925 commented 4 years ago

Hi @1480c1 , The patch looks good and I have tested it. But I can not find your name in Signed-off-by list. How did you make the patch?

1480c1 commented 4 years ago

Hi, my workflow usually looks like

cd FFmpeg
git fetch --all
git reset --hard upstream/master
git am -3 ../SVT-HEVC/ffmpeg_plugin/0001*
# Fix conflicts
git add # conflicting files
git am --continue
git format-patch upstream/master

Since my changes don't actually add code that changes the logical output of the patch nor review and verify the code within myself, I did not sign off on it. If it's preferred, I can sign off on the patch

tianjunwork commented 4 years ago

@1480c1 your choice of adding sign-off, which shows your contribution to this patch.

1480c1 commented 4 years ago

Then I will wait until I fully review the patch and make sure it's something I am content with adding my name to before signing off

1480c1 commented 4 years ago

added my signoff