Closed 1480c1 closed 4 years ago
Hi @1480c1 , The patch looks good and I have tested it. But I can not find your name in Signed-off-by list. How did you make the patch?
Hi, my workflow usually looks like
cd FFmpeg
git fetch --all
git reset --hard upstream/master
git am -3 ../SVT-HEVC/ffmpeg_plugin/0001*
# Fix conflicts
git add # conflicting files
git am --continue
git format-patch upstream/master
Since my changes don't actually add code that changes the logical output of the patch nor review and verify the code within myself, I did not sign off on it. If it's preferred, I can sign off on the patch
@1480c1 your choice of adding sign-off, which shows your contribution to this patch.
Then I will wait until I fully review the patch and make sure it's something I am content with adding my name to before signing off
added my signoff
Description
Move some of the lines to allow patching the master branch, 4.3, and 4.2 with the same file
tested with ffmpeg tags n4.2, n4.3, and n4.4-dev tested with ffmpeg branch master, release/4.2, and release/4.3
@guojiansheng0925 can you please review?
Issue
Author(s)
@1480c1
Performance impact
Merge method