search

OpenVisualCloud / SVT-HEVC

SVT HEVC encoder. Scalable Video Technology (SVT) is a software-based video coding technology that is highly optimized for Intel® Xeon® processors. Using the open source SVT-HEVC encoder, it is possible to spread video encoding processing across multiple Intel® Xeon® processors to achieve a real advantage of processing efficiency.
Other
518 stars 170 forks source link

fix EB_ENC_PD_ERROR4 EB_ENC_PD_ERROR8 in race conditions #580

Closed inteltiger closed 3 years ago

inteltiger commented 3 years ago

double release leads to duplicated objects in empty queue

tianjunwork commented 3 years ago

Hi @inteltiger , could you include sample app command line to reproduce the error?

inteltiger commented 3 years ago

SvtHevcEncApp -i /home/media/Videos/8k2D_musician_360_h265.yuv -b temp.bin -w 7680 -h 3840 -encMode 10 -fps 30 -inj-frm-rt 30 -intra-period 4 -rc 1 -tbr 25000 -lad 0 -irefresh-type 0 -pred-struct 0 -n 300

tianjunwork commented 3 years ago

The tbr is quite low for 8k. Is this a test or real usage? What is the reproduce rate? I tried once, didn't see error.

inteltiger commented 3 years ago

you can use tbr = 100000 * 1000 . this is a real usage.

inteltiger commented 3 years ago

updated my PR, please consider it as a fixup of the following commit of @Austin-Hu https://github.com/OpenVisualCloud/SVT-HEVC/commit/b2530415115efeb492923cc3d0604cf2b070a9b9

tianjunwork commented 3 years ago

Also, could you add sign-off line in git commit message? DCO test is failing.

inteltiger commented 3 years ago

@tianjunwork @Austin-Hu I have verified in my project these days, the patch worked well. shall we continue the PR review?

tianjunwork commented 3 years ago

Hi @inteltiger , for fixing comments or incremental changes, just add new commits in your branch. No need to force push. The change history is lost.