OpenVisualCloud / Smart-City-Sample

The smart city reference pipeline shows how to integrate various media building blocks, with analytics powered by the OpenVINO™ Toolkit, for traffic or stadium sensing, analytics and management tasks.
BSD 3-Clause "New" or "Revised" License
191 stars 82 forks source link

GB28181 enable #726

Closed QuPengfei closed 3 years ago

nnshah1 commented 3 years ago

@QuPengfei What's the goal here? I see we are adding back a local version of vaserving? (Is that correct or am I missing something)

I would definitely want to know the reason and avoid that if at all possible (want to keep it coming from a VA Serving tagged release)

QuPengfei commented 3 years ago

Can you reuse ffmpeg from one of the OVC software stacks?

yes. update with openvisualcloud/xeon-centos7-media-ffmpeg

QuPengfei commented 3 years ago

@QuPengfei What's the goal here? I see we are adding back a local version of vaserving? (Is that correct or am I missing something)

I would definitely want to know the reason and avoid that if at all possible (want to keep it coming from a VA Serving tagged release)

some user met the issue when building the image with vaserving from github. so we keep it in local and avoid that. it does not occur for all the users.

nnshah1 commented 3 years ago

@QuPengfei What's the goal here? I see we are adding back a local version of vaserving? (Is that correct or am I missing something) I would definitely want to know the reason and avoid that if at all possible (want to keep it coming from a VA Serving tagged release)

some user met the issue when building the image with vaserving from github. so we keep it in local and avoid that. it does not occur for all the users.

Please provide more details - would like to fix the root cause. Making it local will be difficult to support / maintain -

QuPengfei commented 3 years ago

@QuPengfei What's the goal here? I see we are adding back a local version of vaserving? (Is that correct or am I missing something) I would definitely want to know the reason and avoid that if at all possible (want to keep it coming from a VA Serving tagged release)

some user met the issue when building the image with vaserving from github. so we keep it in local and avoid that. it does not occur for all the users.

Please provide more details - would like to fix the root cause. Making it local will be difficult to support / maintain -

that is related to network in PRC. some user 's network are not reliable. that will cause the failure to fetch files.

nnshah1 commented 3 years ago

@QuPengfei What's the goal here? I see we are adding back a local version of vaserving? (Is that correct or am I missing something) I would definitely want to know the reason and avoid that if at all possible (want to keep it coming from a VA Serving tagged release)

some user met the issue when building the image with vaserving from github. so we keep it in local and avoid that. it does not occur for all the users.

Please provide more details - would like to fix the root cause. Making it local will be difficult to support / maintain -

that is related to network in PRC. some user 's network are not reliable. that will cause the failure to fetch files.

@QuPengfei Can you help us reproduce it?

I believe we can trim down so it is more repeatable and/or mirror to a PRC friendly github. How do you handle this for Smart Cities in general?

@whbruce

xwu2git commented 3 years ago

The big issue here is that wget sometimes does not return proper error code if a download is not complete, which causes all sorts of silent-failure strange behaviors. In unreliable network, this is 1 more thing we want to avoid. The alternative I can think of is to have the upstream targz the archive. Any corrupted download will fail the unzip process. Or we use md5sum, which is overkill.

xwu2git commented 3 years ago

@QuPengfei, can you decouple the vaserving piece with another commit? Let's get gb28181 in first.

QuPengfei commented 3 years ago

@nnshah1 @xwu2git Now it is only GB28181 feature. will refine va service later.

whbruce commented 3 years ago

We have addressed similar PRC download issues for gstreamer images, but the same approach will work for ffmpeg. The following process should only result in one wget call - to download VA serving source code

  1. Get VA Serving code from release tarball instead of git
  2. Use a pre-built base image. Release 0.4 uses openvisualcloud/xeone3-ubuntu1804-analytics-ffmpeg:20.10 by default

As our models are no longer checked in, the build process now downloads of the OpenVINO data_dev image for model conversion.

QuPengfei commented 3 years ago

We have addressed similar PRC download issues for gstreamer images, but the same approach will work for ffmpeg. The following process should only result in one wget call - to download VA serving source code

  1. Get VA Serving code from release tarball instead of git
  2. Use a pre-built base image. Release 0.4 uses openvisualcloud/xeone3-ubuntu1804-analytics-ffmpeg:20.10 by default

As our models are no longer checked in, the build process now downloads of the OpenVINO data_dev image for model conversion.

will file a new PR about VA service