Closed JarbasAl closed 5 months ago
Attention: Patch coverage is 58.33333%
with 5 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
dev@18f4e11
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
ovos_workshop/skills/ovos.py | 66.66% | 3 Missing :warning: |
ovos_workshop/skills/common_query_skill.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
when using
self.add_event
we can now request that BEFORE the handler fires the skill isactivated
ordeactivated
once this is adopted in core this line should be deleted https://github.com/OpenVoiceOS/ovos-core/blob/dev/ovos_core/intent_services/__init__.py#L296
and that will fix https://github.com/OpenVoiceOS/ovos-core/issues/450 (test need to be updated)
before either PR the event order is messy (extra messages omitted)
with BOTH PRs the new events order becomes
and now we can use deactivate inside skills as documentation says
this PR should be merged first, there is no consequence for older core versions, just means an extra activation event will be emitted, that should be harmless and only happen on partial updates (update workshop but not ovos-core)