OpenVoiceOS / OVOS-workshop

frameworks, templates and patches for the OpenVoiceOS universe
Apache License 2.0
4 stars 11 forks source link

feat - verbosity level #203

Open JarbasAl opened 1 month ago

JarbasAl commented 1 month ago

i propose adding a new concept of VerbosityLevel

this would correspond to a integer from 0 - 10, added to Session

a skill would check for self.verbosity_level (session aware) and conditionally speak more messages, backwards compat is retained

if self.verbosity_level > 3:
    self.speak("extra info")
if self.verbosity_level >= 9:
    self.speak("extra very redundant info")

using session allows verbosity level to be set per client (such as hivemind voice satellites), the default value would come from mycroft.conf as usual. a companion skill can also be made to control this by voice

mike99mac commented 1 month ago

0 corresponds to the default, Just my two cents - I set the default to 1, and use 0 for "silent mode".

JarbasAl commented 1 month ago

0 is the minimum ammount of speech, and needs to correspond to current behavior for compat reasons

if a self.speak is optional then the skill dev can require other verbosity level, we should not force 0 to mean silent, some messages might be mission critical and very important

dont want the carbon monoxide leak detector to not speak because you said "good night mycroft" right?