search

OpenVoiceOS / OVOS-workshop

frameworks, templates and patches for the OpenVoiceOS universe
Apache License 2.0
4 stars 12 forks source link

Since version 0.0.12a26, settings are not reloaded with my skill #91

Closed goldyfruit closed 1 year ago

goldyfruit commented 1 year ago

Before version 0.0.12a26, if I changed the content of settings.json, it got detected and the skill reloads the settings.

Since version 0.0.12a26 (this change https://github.com/OpenVoiceOS/OVOS-workshop/commit/70bc851c88702f0350c57a7b75d57cb24ae37303), any changes in settings.json are not detected anymore.

Here is the skill https://github.com/smartgic/skill-sonos-controller/blob/21.2.1.1/__init__.py#L372-L390

goldyfruit commented 1 year ago

Just did few more test with fresh build and I'm still able to validate that version 0.0.12a25 get the changes but not versions above.

goldyfruit commented 1 year ago

I'm wondering if its not related to the __init__() method.

emphasize commented 1 year ago

Doesn't help much, but SkillSettingsTests should be written

Lets work backwards from how settings.json is monitored