search

OpenVoiceOS / ovos-PHAL-plugin-homeassistant

HomeAssistant PHAL Plugin for OpenVoice OS
Apache License 2.0
10 stars 3 forks source link

consider moving to websocket-client>=0.54.0 instead, as it is already a dependency of ovos-bus-client #58

Open JarbasAl opened 2 months ago

JarbasAl commented 2 months ago 
          consider moving to websocket-client>=0.54.0 instead, as it is already a dependency of ovos-bus-client and always available, always good to keep dependencies to a minimum and both of these do the same  thing

aditionally, i dont remember what package it was, but websockets~=10.4 was conflicting with something 3rd party dependency too

EDIT: it's https://github.com/OpenVoiceOS/ovos-PHAL-plugin-homeassistant/issues/55 , but will likely happen again in the future, say on version 13.0 .....

(no need to be in this PR, but i'd like that for next stable release)

_Originally posted by @JarbasAl in https://github.com/OpenVoiceOS/ovos-PHAL-plugin-homeassistant/pull/57#discussion_r1621572110_