Closed JarbasAl closed 3 weeks ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request introduces enhancements to the audio playback functionality in the ovos_audio/audio.py
file, including a new private method for extracting audio streams from track URIs. Additionally, the requirements/extras.txt
file has been updated to include new dependencies for TTS and media playback, improving the overall capabilities of the project. The GitHub Actions workflow for unit tests has also been modified to ensure that additional dependencies are included during testing.
File | Change Summary |
---|---|
ovos_audio/audio.py | Added a private method _extract for converting track URIs into playable streams; modified play method. |
requirements/extras.txt | Added dependencies: ovos-tts-plugin-server , ovos_audio_plugin_simple , and ovos-audio-plugin-mpv . |
.github/workflows/unit_tests.yml | Changed installation command to include extra dependencies during unit tests. |
test/unittests/test_end2end.py | Added a new test case test_youtube for validating YouTube URL handling in audio service. |
test/unittests/test_service.py | Introduced TestStreamExtract class to test _extract method functionality. |
Objective | Addressed | Explanation |
---|---|---|
OCP extractors failing when OCP is set to legacy audio service (#81) | ✅ | The introduction of the _extract method addresses the extraction failure for audio streams. |
_extract
method in ovos_audio/audio.py
, which is also a key feature of the main PR. Both PRs enhance audio playback functionality by ensuring that track URIs are converted into playable streams.🐇 In the land of audio streams,
A rabbit hops and gleams,
With plugins new and bright,
Playback dances in delight,
Extracting tunes with flair,
Hopping high without a care! 🎶
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
use the stream extractors before delegating to audio service
allows directly sending things such as youtube urls to the audio service bus api
closes https://github.com/OpenVoiceOS/ovos-audio/issues/81
Summary by CodeRabbit
New Features
Bug Fixes