search

OpenVoiceOS / ovos-config

OVOS configuration manager library
Apache License 2.0
2 stars 10 forks source link

revert to single thread #137

Closed JarbasAl closed 4 months ago

JarbasAl commented 4 months ago

use single_thread for padatious by default

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (dev@54cda72). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #137 +/- ## ===================================== Coverage ? 0.00% ===================================== Files ? 10 Lines ? 826 Branches ? 0 ===================================== Hits ? 0 Misses ? 826 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikejgray commented 4 months ago

Turning on multithreading caused an out of control number of processes and threads to spawn during Padatious training when I tested on Mac. Not sure if it happens like that for Linux.

goldyfruit commented 4 months ago

I did not notice this behavior on Linux.

JarbasAl commented 4 months ago

I did not notice this behavior on Linux.

consider tuning this on the installer if that is the case

for now i reverted to the old default as i don't fully understand why this is even an option, i suspect some weirdness in padatious...

when it is extracted into it's own plugin we can revisit this and if it even makes sense to expose as a config option or not