OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
147 stars 17 forks source link

Deregister any entities when a skill is detached. Fixes #394 #395

Closed lbt closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (835ac34) 60.90% compared to head (a96013a) 60.83%. Report is 9 commits behind head on dev.

:exclamation: Current head a96013a differs from pull request most recent head 0154c34. Consider uploading reports for the commit 0154c34 to get more accurate results

Files Patch % Lines
ovos_core/intent_services/padacioso_service.py 50.00% 6 Missing :warning:
ovos_core/intent_services/adapt_service.py 60.00% 2 Missing :warning:
ovos_core/intent_services/padatious_service.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #395 +/- ## ========================================== - Coverage 60.90% 60.83% -0.08% ========================================== Files 13 13 Lines 1857 1879 +22 ========================================== + Hits 1131 1143 +12 - Misses 726 736 +10 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/395/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `60.83% <58.33%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lbt commented 10 months ago

Depends on https://github.com/OpenVoiceOS/OVOS-workshop/pull/171