OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
128 stars 18 forks source link

Update skills-essential.txt #401

Closed JarbasAl closed 6 months ago

JarbasAl commented 8 months ago

update default skills list

should we add a list with OCP skills only?

what about GUI only skills? like homescreen

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cf8b6b5) 62.72% compared to head (2433741) 63.11%. Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #401 +/- ## ========================================== + Coverage 62.72% 63.11% +0.39% ========================================== Files 14 14 Lines 2039 2039 ========================================== + Hits 1279 1287 +8 + Misses 760 752 -8 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `63.11% <100.00%> (+0.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

emphasize commented 8 months ago

rationale for ocp skills? I see GUI skills for headless distributions.

builderjer commented 8 months ago

maybe a meta package for OCP and GUI? Instead of making it an option with core.

ovos-media-packages ovos-gui-packages

Then users can just install that meta package and have what they need. It keeps the minimal amount in core requirements itself

emphasize commented 8 months ago

LGTM, is the OVOS alerts skill ready for prime time? I thought it still had some work to do

Needs translation other than german and that is hard to come by and needs someone who is a heavy user, not only the usual example test. Everything other than "en_us" (and "de-de" ofc) is autotranslated and bound to failure. But that's the way it is. Its Adapt intent, so you have more freedom how to form a sentence, but the parser may butcher the event/reminder name.

A reason why list todos are recorded one by one (looping get_response) without parsing as this would be a mess.

JarbasAl commented 7 months ago

https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added

mikejgray commented 7 months ago

https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added

Need to get it on PyPi first

builderjer commented 7 months ago

Not sure it should be included in the defaults. It is a great extra, but I think the default should be kept to a minimum

builderjer commented 6 months ago

And looking through things, is this needed as a requirement when we don't require precise?