Closed JarbasAl closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cf8b6b5
) 62.72% compared to head (2433741
) 63.11%. Report is 1 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
rationale for ocp skills? I see GUI skills for headless distributions.
maybe a meta package for OCP and GUI? Instead of making it an option with core.
ovos-media-packages
ovos-gui-packages
Then users can just install that meta package and have what they need. It keeps the minimal amount in core requirements itself
LGTM, is the OVOS alerts skill ready for prime time? I thought it still had some work to do
Needs translation other than german and that is hard to come by and needs someone who is a heavy user, not only the usual example test. Everything other than "en_us" (and "de-de" ofc) is autotranslated and bound to failure. But that's the way it is. Its Adapt intent, so you have more freedom how to form a sentence, but the parser may butcher the event/reminder name.
A reason why list todos are recorded one by one (looping get_response) without parsing as this would be a mess.
https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added
https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added
Need to get it on PyPi first
Not sure it should be included in the defaults. It is a great extra, but I think the default should be kept to a minimum
And looking through things, is this needed as a requirement when we don't require precise
?
update default skills list
should we add a list with OCP skills only?
what about GUI only skills? like homescreen