search

OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
147 stars 17 forks source link

fix: blacklisted skills #424

Closed JarbasAl closed 8 months ago

JarbasAl commented 8 months ago

closes https://github.com/OpenVoiceOS/ovos-core/issues/383

missed in https://github.com/OpenVoiceOS/ovos-core/pull/313 apparently

logs should have

2024-02-28 22:01:00.559 - skills - ovos_core.skill_manager:_load_on_startup:540 - INFO - Loading offline skills...
2024-02-28 22:01:03.834 - skills - ovos_core.skill_manager:load_plugin_skills:334 - WARNING - skill-ovos-stop.openvoiceos is blacklisted, it will NOT be loaded
2024-02-28 22:01:03.834 - skills - ovos_core.skill_manager:load_plugin_skills:335 - INFO - Consider uninstalling skill-ovos-stop.openvoiceos instead of blacklisting it
codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 63.85%. Comparing base (20689d1) to head (1088097).

Files Patch % Lines
ovos_core/skill_manager.py 25.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #424 +/- ## ========================================== - Coverage 64.12% 63.85% -0.28% ========================================== Files 15 15 Lines 2570 2584 +14 ========================================== + Hits 1648 1650 +2 - Misses 922 934 +12 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/424/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/424/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `63.85% <25.00%> (-0.28%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikejgray commented 8 months ago

Also some tests would be awesome here, so coverage doesn't drop while we're targeting 75% 🙂