OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
147 stars 17 forks source link

fix: old mycroft skills loading #426

Closed JarbasAl closed 8 months ago

JarbasAl commented 8 months ago

improve logs for old style skills

restore the /opt/mycroft/skills path until version 0.1.0, part of https://github.com/OpenVoiceOS/ovos-core/issues/420

remove old method around git locks, this does nothing in OVOS as we dont have msm git cloning skills

2024-03-02 20:03:32.972 - skills - ovos_workshop.skill_launcher:load:282 - INFO - ATTEMPTING TO LOAD SKILL: skill-autogui
2024-03-02 20:03:33.121 - skills - ovos_workshop.skills.mycroft_skill:__call__:114 - WARNING - Legacy skill signature detected for skill-autogui; attempting to init skill manually, self.bus and self.skill_id will only be available in self.initialize. `__init__` method needs to accept `skill_id` and `bus` to resolve this.
2024-03-02 20:03:33.122 - skills - ovos_workshop.skills.mycroft_skill:MycroftSkill.__init__ - WARNING - Deprecation version=0.1.0. Caller=ovos_workshop.decorators.compat:40. MycroftSkill class has been deprecated, please subclass from OVOSSkill
2024-03-02 20:03:33.132 - skills - ovos_utils.gui:get_ui_directories:97 - INFO - Checking for legacy UI directories
2024-03-02 20:03:33.356 - skills - ovos_workshop.skill_launcher:_communicate_load_status:497 - INFO - Skill skill-autogui loaded successfully
2024-03-02 20:03:33.359 - skills - ovos_core.skill_manager:_load_skill:605 - INFO - Loaded old style skill: /opt/mycroft/skills/skill-autogui
codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.99%. Comparing base (f0cd346) to head (b354c64). Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/skill_manager.py 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #426 +/- ## ========================================== + Coverage 63.85% 63.99% +0.13% ========================================== Files 15 15 Lines 2584 2580 -4 ========================================== + Hits 1650 1651 +1 + Misses 934 929 -5 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/426/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `63.99% <40.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.