OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
147 stars 17 forks source link

refactor/reduce code complexity #427

Closed JarbasAl closed 8 months ago

JarbasAl commented 8 months ago

extract an helper method from the utterance handler to improve readibility and reduce code complexity

handle the case where a pipeline plugin returns a bad intent match object

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.98%. Comparing base (6e3242c) to head (93aec67). Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/__init__.py 88.88% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #427 +/- ## ========================================== - Coverage 63.99% 63.98% -0.01% ========================================== Files 15 15 Lines 2580 2585 +5 ========================================== + Hits 1651 1654 +3 - Misses 929 931 +2 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/427/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `63.98% <88.88%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.