search

OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
147 stars 17 forks source link

Update SkillManager logging and optimize infinite loop #432

Closed NeonDaniel closed 7 months ago

NeonDaniel commented 7 months ago

Update logging to prevent extra logs in the skill loading loop Optimize skill loading loop to exit more quickly and use fewer CPU cycles Closes #431

NeonDaniel commented 7 months ago

Confirmed prior to the second commit that this did reduce logging to once every 30s. Issue partially attributable to a bug in Neon OS where the clock was not guaranteed to update before services start.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.01%. Comparing base (431edb5) to head (3fb9e7a). Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/skill_manager.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #432 +/- ## ========================================== + Coverage 66.66% 67.01% +0.34% ========================================== Files 15 15 Lines 2586 2589 +3 ========================================== + Hits 1724 1735 +11 + Misses 862 854 -8 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/432/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `67.01% <90.00%> (+0.34%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.