fix/ocp_pipeline_config

JarbasAl commented 5 months ago

filter_SEI option didnt account for using legacy audio service

config was also not being passed to the OCPPipeline

{
  "intents": {
    // this should be removed and True by default IMHO
    "experimental_ocp_pipeline": false,

    "OCP": {
      // legacy forces old audio service instead of OCP
      "legacy": false,
      // min confidence (0.0 - 1.0) to accept MediaType
      "classifier_threshold": 0.4,
      // min conf for each result (0 - 100)
      "min_score": 50,
      // filter results from "wrong" MediaType
      "filter_media": true,
      // filter results we lack plugins to play
      "filter_SEI": true,
      // playback mode
      // 0 - auto
      // 10 - audio results only
      // 20 - video results only
      "playback_mode": 0,
      // if MediaType query fails, try Generic query
      "search_fallback": true,
      // enable mycroft common play pipeline
      "legacy_cps": true
    }
  }
}

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.63%. Comparing base (784ad94) to head (129ff29). Report is 1 commits behind head on dev.

Files	Patch %	Lines
ovos_core/intent_services/ocp_service.py	88.88%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #480 +/- ## ========================================== + Coverage 73.58% 73.63% +0.04% ========================================== Files 15 15 Lines 2733 2738 +5 ========================================== + Hits 2011 2016 +5 Misses 722 722 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/480/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/480/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `73.63% <90.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

NeonDaniel commented 4 months ago

Did we define "SEI" anywhere? I'm not sure I understand how those are used as a URI prefix.. They look similar to a URI scheme, but don't quite follow that syntax

JarbasAl commented 4 months ago

Did we define "SEI" anywhere? I'm not sure I understand how those are used as a URI prefix.. They look similar to a URI scheme, but don't quite follow that syntax

those have been around for a long while now, but all we have in docs is this https://openvoiceos.github.io/ovos-technical-manual/ocp_plugins/

a StreamExtractorId is just a prefix to a real URI, SEI//URI

NeonDaniel commented 4 months ago

Opened an issue to continue discussion

OpenVoiceOS / ovos-core

fix/ocp_pipeline_config #480

Codecov Report