OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
122 stars 17 forks source link

fix/several_OCP_issues #481

Closed JarbasAl closed 3 months ago

JarbasAl commented 3 months ago

recommend also having https://github.com/OpenVoiceOS/ovos-utils/pull/246 + https://github.com/OpenVoiceOS/ovos-bus-client/pull/97 but will work without those

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 73.46%. Comparing base (5b3b6da) to head (e6185d4). Report is 2 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/ocp_service.py 63.63% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #481 +/- ## ========================================== - Coverage 73.63% 73.46% -0.17% ========================================== Files 15 15 Lines 2738 2762 +24 ========================================== + Hits 2016 2029 +13 - Misses 722 733 +11 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/481/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/481/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `73.46% <63.63%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.