codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 86.40777% with 14 lines in your changes are missing coverage. Please review.
Project coverage is 74.54%. Comparing base (
0cead56) to head (f29923d).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #484 +/- ## ========================================== + Coverage 73.46% 74.54% +1.08% ========================================== Files 15 15 Lines 2762 2833 +71 ========================================== + Hits 2029 2112 +83 + Misses 733 721 -12 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/484/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `74.54% <86.40%> (+1.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
adds shutdown method to pipeline components, allowing to deregister bus events etc
removes fallback V1 pipeline, that was only to help in transition, ovos-workshop only uses fallbackV1 if it detects ovos-core <= 0.0.7 it is impossible to use with ovos-core 0.0.8 in a natural way, standalone skills were introduced in core 0.0.8 and also use V2
see https://github.com/OpenVoiceOS/OVOS-workshop/blob/dev/ovos_workshop/skills/fallback.py#L74
when used, it only introduces 10 seconds latency for no good reason
streamlines main.py