OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
122 stars 17 forks source link

enable ocp with utils 0.0.38 compat #491

Closed JarbasAl closed 3 months ago

JarbasAl commented 3 months ago

closes #490

removes the need for a special flag to enable OCP pipeline, now it's just like other pipelines and needs only to be added to "pipeline" config, instead of requiring an additional boolean flag

NOTE: enabling OCP by default needs https://github.com/OpenVoiceOS/ovos-config/pull/96 , this PR just allows it to import with utils <=0.0.38

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 48.76033% with 124 lines in your changes are missing coverage. Please review.

Project coverage is 73.18%. Comparing base (7f743bc) to head (4ef1a87). Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/ocp_service.py 48.33% 124 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #491 +/- ## ========================================== - Coverage 74.97% 73.18% -1.79% ========================================== Files 15 15 Lines 2821 3051 +230 ========================================== + Hits 2115 2233 +118 - Misses 706 818 +112 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/491/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `73.18% <48.76%> (-1.79%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.