search

OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
122 stars 17 forks source link

fix/ocp_per_session #495

Closed JarbasAl closed 3 months ago

JarbasAl commented 3 months ago

tracks available stream extractors per session, this allows running OCP satellite side

NOTE: with hivemind we need to whitelist "ovos.common_play.SEI.get.response" in the listener

2024-06-05 01:21:25.379 - skills - ovos_core.intent_services.ocp_service:handle_get_SEIs:664 - INFO - Session: 5937ce7a-71e3-4d21-8403-142102c5f759 Available stream extractor plugins: ['rss', 'news', 'm3u', 'pls', 'file', 'youtube', 'ydl', 'youtube.channel.live', 'pytube', 'invidious', 'bandcamp']
2024-06-05 01:21:25.384 - skills - ovos_core.intent_services.ocp_service:_search:1301 - DEBUG - Got 3 usable results
2024-06-05 01:21:25.385 - skills - ovos_core.intent_services.ocp_service:handle_play_intent:984 - DEBUG - Playing 3 results for: ozzy osbourne
2024-06-05 01:21:25.385 - skills - ovos_core.intent_services.ocp_service:select_best:1372 - INFO - OVOSCommonPlay selected: skill-ovos-youtube-music.openvoiceos - 94.61538461538461
JarbasAl commented 3 months ago

this quickly identified some extra issues around session support, marked as draft until i solve those

the player/media state also needs to take session into account

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 74.16667% with 31 lines in your changes missing coverage. Please review.

Project coverage is 73.36%. Comparing base (481c57d) to head (20c4350). Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/ocp_service.py 74.16% 31 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #495 +/- ## ========================================== + Coverage 73.18% 73.36% +0.17% ========================================== Files 15 15 Lines 3051 3101 +50 ========================================== + Hits 2233 2275 +42 - Misses 818 826 +8 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/495/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/495/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `73.36% <74.16%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.